Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom fields #17

Merged
merged 4 commits into from
Oct 29, 2023
Merged

Custom fields #17

merged 4 commits into from
Oct 29, 2023

Conversation

Riktam-Santra
Copy link
Contributor

Description

Added a customSocials field which allows users to create their own fields with their parameters including icons, name and url

Resolves #16

Basic Checklist

  • ✨ Ran dartdoc
  • 🛠️ Added proper documentation
  • ❌ No warnings or errors in the code
  • ✅ If added a new parameter, added in Readme and example too

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Riktam-Santra
Copy link
Contributor Author

In the example I have added my socials since I didn't have a good example, you might want to change that so I haven't updated the screenshot yet on README

@Riktam-Santra
Copy link
Contributor Author

Riktam-Santra commented Oct 18, 2023 •
edited
Loading

Also, looks like your repository has been marked as excluded, you might want to enquire about that
Looks like they removed exculsion on your repository now

AbhishekDoshi26
AbhishekDoshi26 requested changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@AbhishekDoshi26 AbhishekDoshi26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, inside models folder, there should be a barrlel file that will export cutom_field.dart
Same way, inside contactus.dart, add an export to models/models.dart

README.md Outdated Show resolved Hide resolved
example/lib/main.dart Outdated Show resolved Hide resolved
lib/models/custom_field.dart Outdated Show resolved Hide resolved
@AbhishekDoshi26 AbhishekDoshi26 merged commit c790951 into AbhishekDoshi26:master Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhishekDoshi26 AbhishekDoshi26 AbhishekDoshi26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to create a custom field
2 participants
@Riktam-Santra @AbhishekDoshi26