Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative example for array jobs with hardcoded parameters, chosen from array instead of case statement #715

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AbsoluteVacuum
Copy link

No description provided.

@eglerean
Copy link
Member

Looks good to me. I would like the teachers of this part of next week's course to be aware of this change since it will be on the course pages so explicit ping to @rkdarst and @simo-tuomisto

@eglerean eglerean requested review from rkdarst and simo-tuomisto May 29, 2024 13:01
@rkdarst
Copy link
Member

rkdarst commented May 29, 2024

This is good, though part of the reason for the case example was that it would be completely obvious to someone looking at it (the goal is more to show how it works to someone that has never seen a shell script, than provide the most recommended solution). I'd rather keep the page shorter and less advanced.

But we should have more advanced and cool array examples somewhere. This would be good there (and maybe we should move another example or two from the page there, too?) An array directory here?: https://github.com/AaltoSciComp/hpc-examples/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants