Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MVP] New Memo app design #57

Merged
merged 57 commits into from
Oct 25, 2024
Merged

[MVP] New Memo app design #57

merged 57 commits into from
Oct 25, 2024

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Apr 17, 2024 •
edited
Loading

Description

Implement new Memo app design for first MVP version.

#55

Screenshot

1 2 3 4 5 6 7 8 9 10 11
test1 test2 test11 test3 test4 test5 test6 test7 test8 test9 test10

Limitations

  • Minimal function for graphic notes. -> This is now fully functional.
  • Voice memos might not fully functional yet (missing voice note detail view UI design). -> Voice note detail view UI is now implemented.
  • Search does not function yet. -> This is now supported with commit a85f62f
  • Graphic note's thumb is not there in Note list on Home yet.

@tuancoltech tuancoltech added enhancement New feature or request do not merge labels Apr 17, 2024
@tuancoltech tuancoltech self-assigned this Apr 17, 2024
@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch from 0f14c26 to 981f1b9 Compare May 1, 2024 09:36
@kirillt kirillt requested a review from hieuwu May 5, 2024 09:24
@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch from 1b4abdc to cfdac94 Compare May 12, 2024 14:21
tuancoltech
tuancoltech commented May 12, 2024
View reviewed changes
app/src/main/java/dev/arkbuilders/arkmemo/models/Tag.kt
Comment on lines +1 to +7
package dev.arkbuilders.arkmemo.models

import android.os.Parcelable
import kotlinx.parcelize.Parcelize

@Parcelize
data class Tag(val value: String) : Parcelable
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not yet implemented in MVP version, but might be there in post MVP.
So I'd like to keep it around.

tuancoltech
tuancoltech commented May 12, 2024
View reviewed changes
app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/TagAdapter.kt
@@ -0,0 +1,33 @@
package dev.arkbuilders.arkmemo.ui.adapters
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag feature is not yet implemented in MVP version, but might be there in post MVP.
So I'd like to keep this class around.

@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch from cfdac94 to 8d5deed Compare May 12, 2024 15:13
@tuancoltech tuancoltech changed the title WIP: New Memo app design [MVP] New Memo app design May 12, 2024
@tuancoltech tuancoltech requested review from kirillt and shubertm May 12, 2024 15:31
@tuancoltech tuancoltech force-pushed the feature/new_ui_design branch from fbffc9f to b1815b9 Compare May 15, 2024 15:12
@tuancoltech
Bug fixes including:
d93fea5 
* Button Save/Paste are not working in Text Note edit mode
* Correct Start over action when recording voice memo
* Enhance voice memo recording/playback UI
@tuancoltech
[opt] Reuse dialog showing logic between notes edit screen
f083e4a
@shubertm
Copy link
Member

shubertm commented Sep 26, 2024 •
edited
Loading

search.back.mp4
  • Pressing back button while searching should not close app but move out of search state
wave.changes.mp4
  • Observe carefully the playback waves are changing for the same voice note on each play
SVID_20240926_211518_1.mp4
  • Play audio, rotate device and play audio again... It starts misbehaving
SVID_20240923_150812_1.mp4
  • Back button closes recording screen suddenly while recording is active

@tuancoltech
Copy link
Collaborator Author

search.back.mp4

  • Pressing back button while searching should not close app but move out of search state

@shubertm By move out of search state, do you mean hiding the cursor from text box?
Could you please help clarify this with @kirillt and Imam about our expected behavior here?
IMHO the current behavior is quite natural in terms of UX.

@shubertm
Copy link
Member

search.back.mp4

  • Pressing back button while searching should not close app but move out of search state

@shubertm By move out of search state, do you mean hiding the cursor from text box?
Could you please help clarify this with @kirillt and Imam about our expected behavior here?
IMHO the current behavior is quite natural in terms of UX.

Alright, let's discuss

@tuancoltech
* Handle back pressed while search box is in focused: #57 (comment)
6025e79 
* Ask for confirmation when back is pressed while record is on-going, clear recording resource when record is discarded: #57 (comment)
@tuancoltech
Copy link
Collaborator Author

tuancoltech commented Sep 29, 2024 •
edited
Loading

search.back.mp4

  • Pressing back button while searching should not close app but move out of search state

SVID_20240923_150812_1.mp4

  • Back button closes recording screen suddenly while recording is active

@shubertm Back pressed action is now handled as per expected for the above 2 cases:

1. While search is in focus
2. While there's on-going recording:

For this, currently recording will be stopped and Save confirmation will be asked if back is pressed while there's on-going recording. If Save is chosen, voice note is saved. Otherwise, the temp recording file will be deleted.

Please help verify.

@tuancoltech
* Enhance the audio play back wave sound visualization's stability by…
8293c69 
… using FFT-based magnitude instead of using wave form data

* Disable auto-recreation of activity upon device's rotation to avoid unwanted issues until landscape mode design is finished (post MVP)
@tuancoltech
Copy link
Collaborator Author

wave.changes.mp4

  • Observe carefully the playback waves are changing for the same voice note on each play

SVID_20240926_211518_1.mp4

  • Play audio, rotate device and play audio again... It starts misbehaving

@shubertm These 2 issues are now fixed.
Please note that regarding the wave animation, due to current approach of calculating sound magnitude, we cannot guarantee that each single bar in the sound wave will be exactly the same as it it was when playing the same Voice note over & over again.
However, with the new commit, the visualization, or to be more specific, each sound bar's height will be more stable (mostly similar to what it was) when playing the same Voice note again & again.

Please help verify.

@shubertm
Copy link
Member

shubertm commented Oct 1, 2024

search.back.mp4

  • Pressing back button while searching should not close app but move out of search state

SVID_20240923_150812_1.mp4

  • Back button closes recording screen suddenly while recording is active

@shubertm Back pressed action is now handled as per expected for the above 2 cases:

1. While search is in focus 2. While there's on-going recording:

For this, currently recording will be stopped and Save confirmation will be asked if back is pressed while there's on-going recording. If Save is chosen, voice note is saved. Otherwise, the temp recording file will be deleted.

Please help verify.
Why not pause? Maybe user may want to continue recording

@tuancoltech
* Fix playback animation displayed as dots after rotating screen
4b0350d 
* Fix swipe to delete issues: Item disappear after discarding confirmation. Deleted item appears again after deletion confirm & scrolling up/down
* Restore previous scroll position when pressing back twice from Note search screen with non-empty search keyword
@tuancoltech
Enhance Voice note playback: Pause the animation and timer when audio…
960e406 
… is paused, and continue from where it's paused when resume
@tuancoltech
Copy link
Collaborator Author

@shubertm Is it good to merge now?

@shubertm
Copy link
Member

shubertm commented Oct 24, 2024 •
edited
Loading

@shubertm Is it good to merge now?

Let's merge now. The rest of your PRs should follow up in main branch. Good job 👍

@tuancoltech tuancoltech merged commit dc9acdd into main Oct 25, 2024
2 checks passed
tuancoltech added a commit that referenced this pull request Oct 25, 2024
@tuancoltech
* Handle back pressed while search box is in focused: #57 (comment)
2a192d8 
* Ask for confirmation when back is pressed while record is on-going, clear recording resource when record is discarded: #57 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt kirillt left review comments

@shubertm shubertm shubertm approved these changes

@hieuwu hieuwu hieuwu approved these changes

Assignees

@tuancoltech tuancoltech

Labels
enhancement New feature or request QA_passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuancoltech @shubertm @kirillt @hieuwu