Remove bare get_timeinfo, repoint tests to GenericTimeParser

[marc-white]

Closes #314 .

The simple PR removes source.utils.get_timeinfo, which has been superseded by GenericTimeParser. The related tests have been switched to use that Parser.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (1e08b06) to head (ca760bf).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   98.14%   98.40%   +0.25%     
==========================================
  Files          11       11              
  Lines        1024      940      -84     
==========================================
- Hits         1005      925      -80     
+ Misses         19       15       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-turner-1]

Looks good to me.

Have you got any idea why codecov is so upset about the changes? It's flagged lines don't really make any sense to me, but I wonder whether we might want to take a closer look just to be sure...

[marc-white]

Have you got any idea why codecov is so upset about the changes? It's flagged lines don't really make any sense to me, but I wonder whether we might want to take a closer look just to be sure...

I'm assuming that, because I've excised a chunk of 100% covered code, any uncovered code is now a larger proportion of the code base, hence the percentage of uncovered code has gone up, hence CodeCov is angry... but I would have thought it was smart enough to be able to realize that all that's happened is some line removal.

[marc-white]

That being said, you're right, the highlighting is confusing. For example, L117-135 of source/catalog/utils.py is showing both a red exclamation point as being 'uncovered', but there's a green highlight next to that I don't understand... oh, but local pytest-cov is showing those lines as uncovered as well (I was checking the wrong branch earlier). Checking...

[marc-white]

OK, fixed the issue. I'd missed the module-level private helper functions that now weren't being used, so weren't being tested, so Codecov was flagging that correctly as a test coverage lowering.

[charles-turner-1]

Looks good

[charles-turner-1]

OK, fixed the issue. I'd missed the module-level private helper functions that now weren't being used, so weren't being tested, so Codecov was flagging that correctly as a test coverage lowering.

I came across this extension the other day - might help with that sort of unused function stuff? It basically adds a usage count to function definitions, makes it super easy to see unused functions when traipsing through files.