14-bit CC support #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready to go! Testing LC support would be nice to have but probably not essential, the risk of 3.2/LC differences impacting this code seems relatively low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #63.
This has been lightly tested with a Teensy 3.2 based 16n, controlling Resolume and the unreleased 14-bit branch of the monome plugin for VCV Rack. Sysex messages have been simulated with Max.
Todo:
currently impossible to set the config bit high for faders 8 and 16 because sysex data bytes have to have the high bit low (see comment here.)not in scope for this PR but related:
editor changes(Add support for high-resolution Midi CCs 16n-editor#27)16nx firmware changes(Support high-resolution (14-bit) MIDI CCs. 16next_firmware#15)Max 8 test patch:
16n_14bitCC_sysex_test.zip