Skip to content

Commit

Permalink
set the version number somewhere
Browse files Browse the repository at this point in the history
Fix google#161 

My understanding of the problem is that the version number is not set anywhere. 

pyproject.toml uses a dynamic version number but the dynamic estination is not set, xee package has no __version__ variable. the one in `ext` is using the one from metadata which relies on the pyproject file. 

I decided to start this PR by setting where the dynamic version number should come from. Now I need your review to know where  the hard coded version number should be set.
  • Loading branch information
12rambau authored May 24, 2024
1 parent 53cb53b commit d8b3965
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,7 @@ preview = true
pyink-indentation = 2
pyink-use-majority-quotes = true

[tool.setuptools_scm]
[tools.setuptools.dynamic]
version = {attr = "xee.__version__"}

[tool.setuptools_scm]

0 comments on commit d8b3965

Please sign in to comment.