Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve data races in tests utilizing go routines #29

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Resolve data races in tests utilizing go routines #29

merged 6 commits into from
Oct 14, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR resolves data races present in some tests that utilize go routines.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have added sufficient documentation in code

@zivkovicmilos zivkovicmilos added the bug fix Functionality that fixes a bug label Oct 13, 2022
@zivkovicmilos zivkovicmilos self-assigned this Oct 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #29 (d6c49df) into main (d583c51) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   94.06%   94.14%   +0.07%     
==========================================
  Files           6        6              
  Lines        1314     1314              
==========================================
+ Hits         1236     1237       +1     
+ Misses         57       56       -1     
  Partials       21       21
Impacted Files Coverage Δ
core/ibft.go 92.86% <0.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zivkovicmilos zivkovicmilos mentioned this pull request Oct 13, 2022
Closed
8 tasks
JekaMas
JekaMas approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@JekaMas JekaMas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

vcastellm
vcastellm approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the suggestion

@zivkovicmilos zivkovicmilos merged commit 20516d0 into main Oct 14, 2022
@zivkovicmilos zivkovicmilos deleted the fix/race-in-tests branch October 14, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JekaMas JekaMas JekaMas approved these changes

@dbrajovic dbrajovic dbrajovic approved these changes

@vcastellm vcastellm vcastellm approved these changes

@trimixlover trimixlover Awaiting requested review from trimixlover

@Kourin1996 Kourin1996 Awaiting requested review from Kourin1996

Assignees

@zivkovicmilos zivkovicmilos

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zivkovicmilos @codecov-commenter @vcastellm @JekaMas @dbrajovic