Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Feature: CSS Markup #118

Open
diemuzi opened this issue Jul 26, 2013 · 5 comments
Open

Feature: CSS Markup #118

diemuzi opened this issue Jul 26, 2013 · 5 comments

Comments

@diemuzi
Copy link
Contributor

diemuzi commented Jul 26, 2013

Would it be possible to add all the CSS Markup into a CSS File so that when you view the source in a browser you don't have to scroll to find your code?

Right now I have to scroll past all the ZDT CSS Markup in the source to look at my own source and it can be quite annoying at times.

@Ocramius
Copy link
Member

@diemuzi the idea is to make everything in a single HTTP request. That's the good/bad part of the toolbar.

@diemuzi
Copy link
Contributor Author

diemuzi commented Jul 26, 2013

Hrmm... Perhaps a flag that we can set to either make it a single request or file based?

OR

Perhaps the CSS can be loaded at the end of the page? That would be fine too actually =)

@Ocramius
Copy link
Member

@diemuzi using a custom CSS placeholder that collects all of the CSS from the various toolbar components would be fine.

@oliverkoenig
Copy link

move style to body:
(http://stackoverflow.com/questions/2830296/using-style-tags-in-the-body-with-other-html)

view/zend-developer-tools/toolbar/style.phtml, Line 2:
< style type="text/css" media="screen" scoped>

src/ZendDeveloperTools/Listener/ToolbarListener.php, Lines 161-162:
$injected = preg_replace('/</body>/i', $style . $toolbar . "\n< / body>", $response->getBody(), 1);
//$injected = preg_replace('/</head>/i', $style . "\n", $injected, 1);

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-developer-tools; a new issue has been opened at laminas/laminas-developer-tools#19.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants