DownThemAll not working since Nightly 118.0a1 Builddate 20230811095324 #274
Comments
|
Thank you very much for the quick fix! |
|
Thanks, working good again. |
|
For keyconfig users here's a working update for nightly 118. It fixes the services issue and another from this bug: https://hg.mozilla.org/integration/autoland/rev/4e6febc59baab7317ec93111d5b7d2caae57ff5f |
|
To @xelsios or anyone else, who might end up working on DTA, My massive gratitude goes to you. If I could only request two very minor additions:
I would really appreciate if you would take these requests into account. Thank you. |
This version fixes DTA so it will load and allows downloads, but right-clicking any download and selecting "Download Information" results in empty elements in "Download Information" tab and incorrect/empty information in the "Options" tab. I get this error when trying to do the above: DownThemAll! (error) - load [Exception: PluralForm is not defined]
getFormattedString@chrome://dta-modules/content/utils.js:559:4
@chrome://dta/content/common/internalFunctions.js:275:18
load@chrome://dta/content/dta/manager/info.js:44:34
@chrome://dta/content/dta/manager/info.js:255:39
EventListener.handleEvent*@chrome://dta/content/dta/manager/info.js:255:17EDIT: I fixed it by changing this in -ChromeUtils.importESModule("chrome://dta-modules/content/PluralForm.sys.mjs");
+const {PluralForm} = ChromeUtils.importESModule("chrome://dta-modules/content/PluralForm.sys.mjs");rename to .xpi and install: |
|
Thanks @mjolnir870 for spotting the error i missed! @hgdagon The clipboard thing was already there, but not functional. Fixed. Import will now list *.txt *.meta4 and *.metalink as default. Also some minor cosmetic changes and tested with the current Release Channel. |
|
Has anyone been able to import a large set of links and then actually add them? The window is too small and unscrollable for me to actually click any of the add-to-queue buttons. |
|
No problem here. Do you have a low res screen? Resize of window not possible? |
It's a 1080p screen. I can't resize the window. Maybe try importing a file with a few dozen links? The window works when there is only one or two links, although it's still not resizable. There are a lot of Adding this to userChrome helped with larger linklists: @-moz-document url("chrome://dta/content/dta/manager/metaselect.xhtml")
{
notificationbox {
height: 74%;
}
#downloads > richlistitem > vbox {
max-width: 100%;
}
#downloads > richlistitem vbox.metalink-infobox {
max-width: 80%;
}
#downloads > richlistitem vbox.metalinker-additional {
max-width: unset;
}
#downloads > richlistitem vbox .metalinker-description {
-moz-padding-start: 3.77em;
}
} |
|
Continuing in this thread, don't see a need to open another. In Dev 119.0b2, DTA context menu entries for links no longer work. Getting this error: |
|
Seems to break again in Nightly starting today (2023-10-03). Cannot invoke the download manager window. |
Noticed it this morning so I did a mozregression, it's from this bug: https://phabricator.services.mozilla.com/D189722 Try this: @xelsios, take a look at it, the change was made in DeferredSave.jsm. |
|
Thanks for the quick fix! Works well for me. |
Does this also fix the problem from this comment with context menu entries for links? Right now I downgraded to 118.0b9 to keep links working. |
No I haven't been able to fix that yet. Context menu entries have been a problem for me since at least 116.0 What I did was add this to userChrome.css to force the only two entries I use to always show and it's been working so far: #dtaCtxTDTA-direct { #dtaCtxTDTASel-direct { /Save Image With DTA/ #dtaCtxSaveImgT-direct { /Save Link With DTA/ #dtaCtxSaveLinkT-direct { |
|
This version should fix both the MetaSelect window problem and the Context Menu bug. |
|
Hi @xelsios, thank you for all the effort you put to fix any bug in DTA. Any chance to take a look on the scheduler? Thanks again!
|
|
I have only corrected the UI. Please test whether the function is as it should be. |
Thank you so much! |
|
I don't suppose anyone can figure out the issue with columns resetting every time the DTA manager window is closed and reopened? I have to reorder and resize them every time. |
|
What order you try to archive? |
Trying to save in the above order, but "Save path" always resets to the 4th column when the window is closed. And the widths always change too. |
|
Change the order in the source file according to your table above. |
|
Hi @xelsios , thank you for the new additions. If I am not mistaken, at some point, we used to also have a 'Date Added' column. Is it possible to bring it back? Thank you. |
|
I've never used DTA before. I installed DownThemAll-3.1.2.119.2023.11.05. What differentiates it from the standard release? Is there a tutorial I can study? I have a few questions/remarks. I went to Youtube to test it. I could only get it to d/l html or image files. It didn't detect the video file. There is no toolbar button. At the moment, I'm only focused on setting it up for downloading media files. I installed the standard Firefox addon version and was able, with no settings alterations, to download only the Youtube video, which is what I prefer with, no settings alterations. I then tried it a second time, and now it will only download the html file. I have selected only the video filter. |
|
@nollinvoyd What do you define as standard release? The 3.1.2. version is based on the last official (non WebExtension) version 3.0.7 from 2016 and has been changed again and again so that it works with the current firefox versions. Since a lot has changed on the internet in the last 7 years, it is not surprising that DTA cannot do anything with the current technologies of video transmissions. I don't know of any way to make it possible for DTA to download HLS or DASH streams. @rosgr100 I had a look at a few old versions, but couldn't find any references to a "Date Added" column anywhere. And for me I added a new shortcut Alt-N to quickly toggle the option "Show only file names in Manager window" without going into the preferences window. |
I thought it was an innocent and straightforward question. Forgive me if I insulted you. I'm just a novice trying to figure out how it differs for the "original", You asked me a question,, and actually defined my inquiry with your the statement that followed. I just wanted to know and how to get it to work as I described. So, essentially, am I correct in concluding it is not equipped to work on YouTube? Can you advise how it can be configured for what I wish to do, and where/what type of sites on which it will successfully operate? |
|
Hi @xelsios - Starting yesterday (or the day before yesterday) DTA looks weird under Nightly. The functionality is OK though. Is it something you can fix? Thanks! 
|
It appears to be a bug in the browser itself. If you go to Tools/Page Info some of the lines are blue. Hopefully it'll get fixed soon. |
Ah didn't notice that... Thanks for sharing! Fingers crossed. |
|
Broken in 126b2. I've noticed:
Some warnings/errors that seem to be triggered druing DTA usage: |
Hi, I noticed the directory button not working since Firefox 125b1, I managed to fix it, I also fixed the toolbar icon not working properly, filters not saving and brought back a feature (bug?) from the original DTA! of being able to open the destination directory even for unfinished and canceled downloads. DownThemAll-3.1.2.125.2024.03.18-xiao.xpi.zip Regarding the second issue of DtaOneClick and TurboSelect saving files in a different directory I also noticed that the download directory history is not being updated, so DtaOneClick and TurboSelect use the last directory in the history, I ran mozregression and got https://bugzilla.mozilla.org/show_bug.cgi?id=232598 as the cause, but I'm not sure how this is messing up DTA!, maybe someone else with more knowledge could take a look at it? |
|
The problem with dTaOneClick has been fixed, but a possible disadvantage (which I have not tested) could be that the private mode, in which the directory history is not saved, is no longer respected. |
|
@xelsios Your build actually breaks dTa OneClick in the Private mode... When I right click a link and choose "Save Link with dTa! OneClick", the "Add Downloads" window pops up. So in Private it's no longer "OneClick", but in the normal mode there is no issue. Will you be able to fix it? |
|
As before, this release does not respect the private mode, it will store the directory history in prefs even in private mode. |
Thank you! This fixes the issue with the browse button not working, not being able to change the download directory for OneClick, etc. Update: One more issue I just noticed. Select multiple links -> DownThemAll! Selection. There is an option to copy all the links (Ctrl-C). It no longer works, the clipboard is not modified. |
Hi, I just fixed the second issue you mention, as for the first one I would need to take a closer look to see if I can fix it, but to me, it doesn't seem to break the extension much as it fixes itself if you right click anywhere else in the browser. This build also fixes the OneClick issues without the compromises introduced with the fix implemented by xelsios (I forgot to share it when I fixed it). |
|
Hi, Thanks to everyone keeping this addon alive. But with the newer versions I'm running into several problems. In private windows the entries in the context menu are doubled, for example there will be two "save image with dta one click" or "save link with dta one click" entries and sometimes one or both won't work to download. You click on them and nothing happens. Another more serious problem is that when exiting the browser it hangs in Task Manager and has to be shut down manually. I don't know if it's profile related since no one else has mentioned it. This started with the 3.1.2.126.2024.05.18-xiao.xpi.zip version so for now I'm staying with mvallesc's 3.1.2.125.2024.03.18-xiao.xpi.zip, which still runs perfectly fine for the most part and doesn't have the double entries. If I have time I'll try to go through the later ones and see if I can figure out where the problem is. |
|
According to marty60, I downloaded DownThemAll-3.1.2.128.2024.06.23-xiao.xpi, but how do I deal with this
I already have these about:config adjustments, but they don't work for me now xpinstall.signatures.required = false |
|
Have you installed the userChromeJS package? You would need that to make these older extensions and scripts work. Another issue might be if you're trying to install it in a release or beta version. I only use nightlies, esrs, and occasional developer versions, they install in those no problem. |
Firefox 127.0.1 stable This one? I just downloaded the latest one to be sure, and still got this
I have a number of scripts, and I used to have a several legacy extensions installed.
|
|
Versions from 117+ need to have this updated utils folder: https://github.com/xiaoxiaoflood/firefox-scripts/files/12099137/utils.zip Also these config files: |
All good now. Thanks I was always a little confused in the past about the benefits of DTA. I could never get it to work. I didn't know there was an addon for it. What's the difference between the standard version and the legacy? What is the main benefit of DTA over other d\l managers? Will it capture video on Youtube? Or elsehere? |
|
My understanding about the newer DTA is that compared to the legacy version it's somewhat limited. I've never tried it so I can't make a fair comparison. In my experience DTA is faster and more efficient than the built-in downloader and it has a separate window that opens and closes automatically, which I like. As for downloading youtube videos: I use the MPC-BE player. Not only does it stream very well but you can easily save the video. You can either plug the url into the player directly or use another addon like "Open in VLC" to open and play it automatically. |
|
I use the https://addons.mozilla.org/en-US/firefox/addon/external-application/ for both, but I find in most cases, they fail in loading the videos. |
Originally posted by @jiangzhenjerry in #265 (comment)
Since the error is not related to the Topic it was mentioned in and it may get lost in the long thread, here a new issue.
With build date 20230811095324 Mozilla removed PluralForm which is used in DTA.
Fixed it in this version. Happy testing!
DownThemAll-3.1.2.118.2023.08.12-xiao.xpi.zip
The text was updated successfully, but these errors were encountered: