Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows build perf] _CompileNativeExecutable is always executed #19609

Open
Tracked by #19611
emaf opened this issue Dec 8, 2023 · 0 comments · May be fixed by #21785
Open
Tracked by #19611

[Windows build perf] _CompileNativeExecutable is always executed #19609

emaf opened this issue Dec 8, 2023 · 0 comments · May be fixed by #21785
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone
.NET 10

Comments

@emaf
Copy link
Contributor

emaf commented Dec 8, 2023

Steps to Reproduce

The linker-cache is not created on Windows, so this target is always executed:
image

Expected Behavior

Actual Behavior

Environment

Version information

Build Logs

Example Project (If Possible)
@emaf emaf added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Dec 8, 2023
@emaf emaf mentioned this issue Dec 8, 2023
Open
15 tasks
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Optimizations in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 26, 2024
haritha-mohan added a commit that referenced this issue Dec 10, 2024
@haritha-mohan
add linker cache as illink task property to ensure its contents are c…
5931d6f 
…opied from mac to windows

once task has terminated and subsequently ensure the target only runs on windows when actually necessary

fixes #19609
@haritha-mohan haritha-mohan linked a pull request Dec 10, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
delighter-sc msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Milestone
.NET 10
Development

Successfully merging a pull request may close this issue.

[msbuild] Fix CompileNativeExecutable target on Windows xamarin/xamarin-macios
3 participants
@rolfbjarne @emaf @samhouts