Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for a navigationCommitted event to inform immediately about the navigation status #788

Open
whimboo opened this issue Sep 24, 2024 · 4 comments · May be fixed by #855
Open

Request for a navigationCommitted event to inform immediately about the navigation status #788

whimboo opened this issue Sep 24, 2024 · 4 comments · May be fixed by #855
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 24, 2024

This is a request from the Playwright folks:

Introduce an event or method to track when a navigation is committed, beyond the current DOMContentLoaded and load events, which would be useful for some client requirements (e.g., 'should return when navigation is committed if commit is specified'). We need to know immediately if the navigation has failed or succeeded.

In Puppeteer this event is named page.frameNavigated.

It's not clear right now where in the HTML spec it could hook into to accurately inform about the status of the current navigation.
@whimboo whimboo added enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Sep 24, 2024
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Request for a navigationCommited event to inform immediately about the navigation status.

The full IRC log of that discussion <simonstewart> Topic: Request for a navigationCommited event to inform immediately about the navigation status
<simonstewart> github: https://github.com//issues/788
<simonstewart> Action: someone in chrome to find out what a `navigationCommited` actually is, and what it corresponds to in a spec

@whimboo whimboo mentioned this issue Oct 24, 2024
Open
@OrKoN
Copy link
Contributor

OrKoN commented Oct 25, 2024

Action: someone in chrome to find out what a navigationCommited actually is, and what it corresponds to in a spec

It happens here https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/document_loader.cc;l=2152;drc=c5f3a25855b895bb587af5dbd8ff3ebfb7be76e1 and I believe it roughly corresponds to this step in the HTML spec https://html.spec.whatwg.org/multipage/browsing-the-web.html#populating-a-session-history-entry:loading-a-document

@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Request for a "navigationCommited" event.

The full IRC log of that discussion <tidoust> Topic: Request for a "navigationCommited" event
<jgraham> RRSAgent: make minutes
<RRSAgent> I have made the request to generate https://www.w3.org/2025/01/08-webdriver-minutes.html jgraham
<tidoust> henrik: Put on the agenda because that is a requirement from Playwright.
<tidoust> ... Opposite of navigation started event that we currently have.
<tidoust> ... This would indicate that a navigation takes place.
<jgraham> q+
<sadym> q+
<tidoust> ack jgraham
<tidoust> ack sadym
<jgraham> q+
<tidoust> sadym: It does make sense for us. The only question is where to put it in the specifications. It seems Alex has an idea to put it in the HTML spec.
<whimboo> so it is actualy the opposite of `navigation aborted` event
<tidoust> ... We do need it as well, we're going to implement.
<whimboo> q?
<tidoust> ack jgraham
<sadym> q+
<tidoust> jgraham: Question was when is the event emitted. It feels it needs someone who understands the invariant of when that event is emitted.
<tidoust> ... Reflect on how easy or hard it is to implement.
<tidoust> ack sadym
<jgraham> q+
<tidoust> sadym: It does make sense for us to emit that event when the document changes. When we see that the navigation is "committed". After that event, the navigation cannot be failed anymore. It can only be aborted.
<tidoust> ack jgraham
<tidoust> jgraham: Is somebody from Google able to make a PR for this, then?
<tidoust> sadym: Yes.
<jgraham> github: https://github.com//issues/788

@OrKoN OrKoN mentioned this issue Jan 13, 2025
Open
6 tasks
@whimboo
Copy link
Contributor Author

whimboo commented Jan 13, 2025

From a discussion with the Playwright folks they propose the following:

There two events called browsingContext.navigationFailed and browsingContext.navigationAborted in the WebDriver BiDi spec, but no browsingContext.navigationCommitted. I'd drop browsingContext.navigationAborted and add browsingContext.navigationCommitted instead.

@whimboo whimboo changed the title Request for a navigationCommited event to inform immediately about the navigation status Request for a navigationCommitted event to inform immediately about the navigation status Jan 13, 2025
@OrKoN OrKoN linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify navigation committed event w3c/webdriver-bidi
3 participants
@whimboo @OrKoN @css-meeting-bot