Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should browsingContext.close resolve early when promptUnload is true #852

Open
juliandescottes opened this issue Jan 10, 2025 · 0 comments
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@juliandescottes
Copy link
Contributor

This comes from a discussion on the following playwright issue. microsoft/playwright#34281

Playwright's page.close https://playwright.dev/docs/api/class-page#page-close will not wait for the tab to close if [runBeforeUnload](https://playwright.dev/docs/api/class-page#page-close-option-run-before-unload) is true. Whereas on the BiDi side, browsingContext.close will only resolve when the browsingContext is closed.

Opening this to discussion to see if that's something we would like to change on the BiDi side.

I imagine a good reason to keep the current behavior is that the command remains consistent regardless of which parameters have been set, and consumers can still decide to avoid waiting for the command if they know a beforeunloadprompt might be triggered.

@juliandescottes juliandescottes added module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

1 participant