Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bikeshed warnings #2227

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix bikeshed warnings #2227

wants to merge 3 commits into from
+536 −3,632

Conversation

timcappalli
Copy link
Member

@timcappalli timcappalli commented Jan 13, 2025 •
edited by pr-preview bot
Loading

Closes #2226

Preview | Diff

@timcappalli
Copy link
Member Author

timcappalli commented Jan 14, 2025 •
edited
Loading

spec-prod@v2 is barfing on the image width percentage. I wonder if this is using an older version of bikeshed?

emlun
emlun approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

What was the change to the SVG files? Just pretty-formatting the XML?

@timcappalli
Copy link
Member Author

timcappalli commented Jan 14, 2025 •
edited
Loading

What was the change to the SVG files? Just pretty-formatting the XML?

There was some weirdness with the syntax being used (one example: height/width being in mm).

@simoneonofri
Copy link
Contributor

thank you @timcappalli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@emlun emlun emlun approved these changes

@MasterKale MasterKale Awaiting requested review from MasterKale

Assignees
No one assigned
Labels
type:editorial
Projects
None yet
Milestone
L3 Candidate Recommendation
Development

Successfully merging this pull request may close these issues.

Clean up bikeshed issues before L3 publish
5 participants
@timcappalli @simoneonofri @emlun @akshayku @nadalin