Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of "effective domain" seems wrong #2205

Open
annevk opened this issue Nov 18, 2024 · 4 comments
Open

Usage of "effective domain" seems wrong #2205

annevk opened this issue Nov 18, 2024 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Nov 18, 2024

No other specification really ought to use "effective domain". That's only for document.domain-related business. I suspect you just want to grab an origin's host and ignore this operation.

@nicksteele
Copy link
Contributor

Why is it only for document.domain-related business? Unclear why we can't use effective domain.

@annevk
Copy link
Member Author

annevk commented Nov 21, 2024

Because the domain field is only set when document.domain is used. Generally that's an internal field for the HTML Standard.

@agl
Copy link
Contributor

agl commented Nov 27, 2024

Thanks for that. I think from the [definition of effective domain] we want to skip the second step, yes? Is there a standard name for "the origin's host or null if the origin is opaque"?

@annevk
Copy link
Member Author

annevk commented Nov 28, 2024

No, but your algorithm already returns early for an opaque origin in the prior step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants