Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Teleport): handle teleport unmount edge case #12705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12702

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+18 B) 38 kB (+13 B) 34.2 kB (+23 B)
vue.global.prod.js 158 kB (+18 B) 57.8 kB (+12 B) 51.5 kB (+59 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12705

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12705

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12705

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12705

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12705

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12705

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12705

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12705

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12705

vue

npm i https://pkg.pr.new/vue@12705

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12705

commit: 1b12b40

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: teleport 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: teleport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Teleport bug]: Unmount Teleport when it is not in use results in an error
1 participant