sizegen: do not ignore type aliases (#17556)

Signed-off-by: Vicent Marti <[email protected]>
vitessio · Jan 16, 2025 · 71ccd6d · 71ccd6d
1 parent b103492
commit 71ccd6d
Show file tree

Hide file tree

Showing 6 changed files with 56 additions and 2 deletions.
diff --git a/go/mysql/collations/colldata/cached_size.go b/go/mysql/collations/colldata/cached_size.go
diff --git a/go/sqltypes/cached_size.go b/go/sqltypes/cached_size.go
diff --git a/go/tools/sizegen/sizegen.go b/go/tools/sizegen/sizegen.go
@@ -163,6 +163,8 @@ func (sizegen *sizegen) generateTyp(tt types.Type) {
 		sizegen.generateKnownType(tt)
 	case *types.Alias:
 		sizegen.generateTyp(types.Unalias(tt))
+	default:
+		panic(fmt.Sprintf("unhandled type: %v (%T)", tt, tt))
 	}
 }
 
@@ -490,9 +492,11 @@ func (sizegen *sizegen) sizeStmtForType(fieldName *jen.Statement, field types.Ty
 		// assume that function pointers do not allocate (although they might, if they're closures)
 		return nil, 0
 
+	case *types.Alias:
+		return sizegen.sizeStmtForType(fieldName, types.Unalias(node), alloc)
+
 	default:
-		log.Printf("unhandled type: %T", node)
-		return nil, 0
+		panic(fmt.Sprintf("unhandled type: %v (%T)", node, node))
 	}
 }
 

diff --git a/go/vt/proto/query/cached_size.go b/go/vt/proto/query/cached_size.go
diff --git a/go/vt/proto/topodata/cached_size.go b/go/vt/proto/topodata/cached_size.go
diff --git a/go/vt/proto/vttime/cached_size.go b/go/vt/proto/vttime/cached_size.go