From d1dcd7b2b8fa8f102e3b73dc3dce02ee95cb8865 Mon Sep 17 00:00:00 2001 From: Brandon Casey <2381475+brandonocasey@users.noreply.github.com> Date: Fri, 25 Sep 2020 13:46:52 -0400 Subject: [PATCH] fix: noop vtt segment loader handle data (#959) We should noop handleData in vtt segment loader so that any captions which we don't support the type of, such as stpp.ttml.im1t from tears of steal widevine unified streaming do not attempt to append to sourceBuffers and cause a player append error. --- src/vtt-segment-loader.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vtt-segment-loader.js b/src/vtt-segment-loader.js index 389c28a61..933b7805c 100644 --- a/src/vtt-segment-loader.js +++ b/src/vtt-segment-loader.js @@ -375,6 +375,10 @@ export default class VTTSegmentLoader extends SegmentLoader { this.handleAppendsDone_(); } + handleData_() { + // noop as we shouldn't be getting video/audio data captions + // that we do not support here. + } updateTimingInfoEnd_() { // noop }