-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: a promise was created in a handler but was not returned from it #36
Comments
jagoda
pushed a commit
to jagoda/memcache-plus
that referenced
this issue
Jun 19, 2018
When autodiscovery fails cache operations are silently queued and are never dequeued. This leaves the client in an unusable state and only warns the consumer if onNetError is provided. Since failed autodiscovery is not recoverable all queued operations should be rejected. Related to victorquinn#36.
jagoda
pushed a commit
to jagoda/memcache-plus
that referenced
this issue
Jun 19, 2018
When autodiscovery fails cache operations are silently queued and are never dequeued. This leaves the client in an unusable state and only warns the consumer if onNetError is provided. Since failed autodiscovery is not recoverable all queued operations should be rejected. Related to victorquinn#36.
jagoda
pushed a commit
to jagoda/memcache-plus
that referenced
this issue
Jun 19, 2018
When autodiscovery fails cache operations are silently queued and are never dequeued. This leaves the client in an unusable state and only warns the consumer if onNetError is provided. Since failed autodiscovery is not recoverable all queued operations should be rejected. Related to victorquinn#36.
victorquinn
pushed a commit
that referenced
this issue
Jun 25, 2018
When autodiscovery fails cache operations are silently queued and are never dequeued. This leaves the client in an unusable state and only warns the consumer if onNetError is provided. Since failed autodiscovery is not recoverable all queued operations should be rejected. Related to #36.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have got a bluebird warning.
Warning: a promise was created in a handler but was not returned from it
is occuring at lib/client.jsL170Warning: a promise was created in a handler but was not returned from it
https://github.com/petkaantonov/bluebird/blob/master/docs/docs/warning-explanations.md
I added a line to client.js:
and the warning is disappeared though
return Promise.resolve()
doesn't look good.Stack traces are like:
I will appreciate your help with this situation.
The text was updated successfully, but these errors were encountered: