New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test test_interrupted_command #131

Closed

aiven-sal opened this issue Dec 2, 2024 · 3 comments

Labels

ci good first issue not-for-changelog

Member

aiven-sal commented Dec 2, 2024

The thread's join has a timeout that is too short and sometimes the test fails e.g.

https://github.com/valkey-io/valkey-py/actions/runs/12115916390/job/33775289852

aiven-sal added good first issue ci not-for-changelog labels

paulorochaoliveira commented Dec 4, 2024 •

edited

Loading

I believe Increasing to 1 second should fix the flakiness of this test. What do you think @aiven-sal ?

Member Author

aiven-sal commented Dec 4, 2024

That should be good enough! Thanks :)

paulorochaoliveira commented Dec 4, 2024

I just opened a PR for this issue.

aiven-sal closed this as completed in

7a66661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment