Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a detailed doc reference for doing rolling upgrades #115

Open
madolson opened this issue May 28, 2024 · 5 comments · Fixed by #155
Open

Create a detailed doc reference for doing rolling upgrades #115

madolson opened this issue May 28, 2024 · 5 comments · Fixed by #155

Comments

@madolson
Copy link
Member

For standalone, sentinel, and cluster mode, we should have crisp documentation explaining how to do a rolling upgrade in various configurations.

@zuiderkwast
Copy link
Contributor

In the cluster tutorial, we have this:


Upgrade nodes in a Valkey Cluster

Upgrading replica nodes is easy since you just need to stop the node and restart it with an updated version of Valkey. If there are clients scaling reads using replica nodes, they should be able to reconnect to a different
replica if a given one is not available.

Upgrading masters is a bit more complex, and the suggested procedure is:

  1. Use CLUSTER FAILOVER to trigger a manual failover of the master to one of its replicas. (See the Manual failover in this topic.)

  2. Wait for the master to turn into a replica.

  3. Finally upgrade the node as you do for replicas.

  4. If you want the master to be the node you just upgraded, trigger a new manual failover in order to turn back the upgraded node into a master.

Following this procedure you should upgrade one node after the other until all the nodes are upgraded.

@madolson
Copy link
Member Author

I still think we should come up with a separate doc just for doing upgrades instead of putting it just in cluster spec. Thoughts?

@zuiderkwast
Copy link
Contributor

Sure, I just shared what I knew I'd seen somewhere.

@madolson
Copy link
Member Author

Thanks! It was helpful, I wasn't aware of it :) I know I had never read that before.

@zuiderkwast
Copy link
Contributor

Seems this one was closed by mistake. The PR #155 listed this issue, but I believe it should have listed #116 instead.

@zuiderkwast zuiderkwast reopened this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants