[nodriver] Some change from 0.32 to 0.33 broke cookies.get_all()

[tecbr]

[nodriver] Some change from 0.32 to 0.33 broke cookies.get_all()
The same problem occurs in version 0.34
The function takes a long time and never returns values.

[sohaib17]

event handler seems to be failing because of exception

Jul 14 10:49:25 websockets.client[80565] : <DEBUG> < TEXT '{"method":"Network.responseReceivedExtraInfo","...,"exemptedCookies":[]}}' [1053 bytes]
Jul 14 10:49:26 uc.connection[80565] : <INFO> TypeError: ("string indices must be integers, not 'str'",)  during parsing of json from event : {'method': 'Network.responseReceivedExtraInfo', 'params': {'requestId': '80755.7', 'blockedCookies': [], 'headers': {'alt-svc': 'h3=":443"; ma=86400', 'cache-control': 'public, max-age=315360000, stale-while-revalidate=315360000, stale-if-error=315360000, immutable', 'cf-cache-status': 'MISS', 'cf-ray': '8a37781dcae4641d-SJC', 'content-encoding': 'br', 'content-type': 'text/html; charset=iso-8859-1', 'date': 'Mon, 15 Jul 2024 05:49:26 GMT', 'nel': '{"success_fraction":0,"report_to":"cf-nel","max_age":604800}', 'pragma': 'public', 'report-to': '{"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v4?s=NO85JPKFngRiMDn50Dzrf7a2KCOQwGhfKVYljrF5oy7%2B9ta2WUSyJtZJ7o%2FL7YR4BbvQMGLbYWguuUoPj2YZuW7bqS7SMPJafSndcLjNIadCxk6k6TM0KYl0BX8ET%2BFU"}],"group":"cf-nel","max_age":604800}', 'server': 'cloudflare', 'vary': 'Accept-Encoding', 'x-content-type-options': 'nosniff\nnosniff', 'x-xss-protection': '1; mode=block\n1; mode=block'}, 'resourceIPAddressSpace': 'Public', 'statusCode': 404, 'cookiePartitionKey': 'https://abc.me', 'cookiePartitionKeyOpaque': False, 'exemptedCookies': []}}
Traceback (most recent call last):
  File "/home/pyenv/lib/python3.12/site-packages/nodriver/core/connection.py", line 567, in listener_loop
    event = cdp.util.parse_json_event(message)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pyenv/lib/python3.12/site-packages/nodriver/cdp/util.py", line 19, in parse_json_event
    return _event_parsers[json["method"]].from_json(json["params"])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pyenv/lib/python3.12/site-packages/nodriver/cdp/network.py", line 4343, in from_json
    CookiePartitionKey.from_json(json["cookiePartitionKey"])
  File "/home/pyenv/lib/python3.12/site-packages/nodriver/cdp/network.py", line 1495, in from_json
    top_level_site=str(json["topLevelSite"]),
                       ~~~~^^^^^^^^^^^^^^^^
TypeError: string indices must be integers, not 'str'

[Fortunato28]

Same error for me while trying to use request event handler

try:
    from nodriver import *
except (ModuleNotFoundError, ImportError):
    import sys, os
    sys.path.insert(0, os.path.join(os.path.dirname(__file__), ".."))
    from nodriver import *

import logging
logging.basicConfig(level=logging.INFO)

async def main():
    global result_requests_id

    browser = await start()

    tab = browser.main_tab
    tab.add_handler(cdp.network.ResponseReceived, receive_handler)

    tab = await browser.get("https://www.google.com")

    await tab.send(cdp.fetch.enable())

    await tab
    await tab.sleep(300)

    await tab.close()
    browser.stop()

async def receive_handler(event: cdp.network.ResponseReceived):
    print(event.type_)

browser = loop().run_until_complete(main())

Any advice?

[devblack]

In: /nodriver/cdp/network.py
=> class CookiePartitionKey => from_json

@classmethod
def from_json(cls, json_input) -> CookiePartitionKey:
    if isinstance(json_input, str):
        return cls(
            top_level_site=json_input,
            has_cross_site_ancestor=False
        )
    elif isinstance(json_input, dict):
        return cls(
            top_level_site=str(json_input["topLevelSite"]),
            has_cross_site_ancestor=bool(json_input["hasCrossSiteAncestor"])