Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD] Fix redundant data masking computations for stores #5496

Open
binarman opened this issue Dec 25, 2024 · 3 comments
Open

[AMD] Fix redundant data masking computations for stores #5496

binarman opened this issue Dec 25, 2024 · 3 comments

Comments

@binarman
Copy link
Contributor

binarman commented Dec 25, 2024

Goal

Rework redundant data masking in store operations with help of linear layout.
Masking mechanism should be able to handle any tensor shapes.

DoD

test_convert_mma2mma tests introduced for AMD hardware in #5495 are fully functional for AMD hardware, i.e. no tests are skipped: https://github.com/triton-lang/triton/pull/5495/files#diff-ac90f00a03feff6747a9c9ac5af1f44bb67e56bf911e05db71a2c1e818e897e7R5730

Hints

See PR #5225 for Nvidia specific implementation.

Since test does not require any actual tensor/matrix cores, older hardware could be used.

For example, radeon 6xxx could be used to run WMMA tests, need to:

@binarman
Copy link
Contributor Author

@simonidaa work on this task next, please.

Before you make a PR, please wait for #5495 to land

@rajveer43
Copy link

would like to work on this

@simonidaa
Copy link
Contributor

already on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants