Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 7.56 hardcoded #4

Open
spficklin opened this issue Jun 8, 2018 · 1 comment
Open

Drupal 7.56 hardcoded #4

spficklin opened this issue Jun 8, 2018 · 1 comment
Assignees

Comments

@spficklin
Copy link
Member

We need to upgrade the rapid install script so that the 7.56 version is not hard-coded and it pulls the most recent version.

@spficklin spficklin assigned spficklin and shawnawsu and unassigned spficklin Jun 8, 2018
@spficklin spficklin added the bug label Jun 8, 2018
@shawnawsu
Copy link
Member

@spficklin I don't see how this would be achievable given that drush dl is deprecated in Drush 9. We'd have to require users to have an older version of drush which isn't ideal, especially if you're running other sites which are D8+. Drush dl is deprecated in favour of installing with composer, so we'd have to require users to also install composer which seems less than ideal than just specifying the version in a wget.

We can update it as new versions come out and it most definitely needs to be updated now since it's pointing to an old version with the security flaw. But the pull request from Abdullah completely rewrites this repo so I'm happy to hand maintenance of it over to them. :)

@shawnawsu shawnawsu added enhancement and removed bug labels Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants