fix(coinmarket): testnets support for trading #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeWall
force-pushed
the
fix/coinmarket-testnets
branch
from
686ff2a to
888104a
Compare
tomasklim
requested changes
Sep 30, 2024
| @@ -479,7 +479,7 @@ export const networks = { | |||
| }, | |||
| }, | |||
| coingeckoId: undefined, | |||
| coingeckoNativeId: undefined, | |||
| coingeckoNativeId: 'test-bitcoin', // fake, coingecko does not have testnets | |||
There was a problem hiding this comment.
Is it possible to upload our own bitcoin/ethereum/... testnet icons to data.trezor.io? If not, please uppercase the placeholder letter
There was a problem hiding this comment.
- fixed in d0e0969
- fixed in d0e0969
- it is possible to upload custom icons, I would create a separate issue for it; for now I changed the placeholder to uppercase
Trading - testnet icons missing #14656
FreeWall
force-pushed
the
fix/coinmarket-testnets
branch
from
888104a to
d0e0969
Compare
|
/rebase |
tomasklim
approved these changes
Oct 1, 2024
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11123871536 |
trezor-ci
force-pushed
the
fix/coinmarket-testnets
branch
from
d0e0969 to
fe367f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some testnet (tBTC, tXRP) support for trading
Related Issue
Resolve #14136
Screenshots:
Before
After