Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add ledger account types in Add coin flow #13767

Closed
2 tasks
vytick opened this issue Aug 12, 2024 · 6 comments
Closed
2 tasks

Allow to add ledger account types in Add coin flow #13767

vytick opened this issue Aug 12, 2024 · 6 comments
Labels
mobile Suite Lite issues and PRs

Comments

@vytick
Copy link
Contributor

vytick commented Aug 12, 2024

We want to enable users to add ledge account types.

  • make this work code wise
  • adapt flow when nonBTC network has more account types. - account types description etc.
@vytick vytick added the mobile Suite Lite issues and PRs label Aug 12, 2024
@vytick vytick moved this to 🎯 To do in Suite Mobile Aug 12, 2024
@vytick
Copy link
Contributor Author

vytick commented Aug 12, 2024

@mnuky What texts do we use with new accounts? Mainly everywhere where we have ledger account type?

For btc like networks we have:

Screenshot 2024-08-12 at 11 18 25

@tomasklim
Copy link
Member

@vytick @enjojoy will deal with the texts soon

@Hannsek
Copy link
Contributor

Hannsek commented Aug 28, 2024

TBH We do not want to enable adding ledger account. At least we should discuss why.
We decided to start the discovery of ledger accounts, but we didn't discuss adding them.

@Hannsek
Copy link
Contributor

Hannsek commented Aug 28, 2024

So let's please keep this under the debug mode for now until we discuss it.

@vytick
Copy link
Contributor Author

vytick commented Aug 28, 2024

Thanks for this intel 🙏

cc @mnuky

@vytick
Copy link
Contributor Author

vytick commented Aug 29, 2024

we are not planning to do this

@vytick vytick closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 👀 Dev done in Suite Mobile Aug 29, 2024
@matejkriz matejkriz moved this from 👀 Dev done to ✅ Approved in Suite Mobile Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
Archived in project
Development

No branches or pull requests

3 participants