Chore/fix url type #13675
Merged
Chore/fix url type #13675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
approved these changes
Aug 6, 2024
peter-sanderson
approved these changes
Aug 6, 2024
peter-sanderson
approved these changes
Aug 6, 2024
komret
force-pushed
the
chore/fix-url-type
branch
from
5a2ab21 to
9aa52fa
Compare
komret
force-pushed
the
chore/fix-url-type
branch
from
9aa52fa to
0d47c23
Compare
packages/suite/src/views/wallet/send/components/Outputs/components/Address/index.tsx
Outdated
Show resolved
Hide resolved
peter-sanderson
approved these changes
Aug 7, 2024
|
QA OK link is https://trezor.io/learn/a/glossary#CashAddr Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamic Urls must be typed
as const, otherwise theUrltype changes tostring.The tighter type helped me found a bug where an href was set to the URL key instead of value. This can be tested with address
1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa. on Bitcoin Cash.Screenshots
before:
after:
