Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite-native): handle font scale to make elements visible #13569

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(suite-native): handle font scale to make elements visible #13569

merged 1 commit into from
Jul 31, 2024

Conversation

matejkriz
Copy link
Member

Description

Quick fixes only, not perfect.

Screenshots:

BEFORE

Screenrecorder-2024-07-30-17-45-32-41.mp4
image image

AFTER

Screenrecorder-2024-07-30-18-07-48-55.mp4
image

@matejkriz matejkriz added mobile Suite Lite issues and PRs UI Issues related to stylistic/aesthetic changes accessibility makes product user friendly for people with disabilities labels Jul 30, 2024
@matejkriz matejkriz requested a review from a team as a code owner July 30, 2024 16:20
@matejkriz matejkriz requested a review from shenkys July 30, 2024 16:21
vytick
vytick approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot and great job fixing this! 💪

@matejkriz matejkriz merged commit 3e3b9ef into develop Jul 31, 2024
15 checks passed
@matejkriz matejkriz deleted the fix/native/font-scale-basic-fixes branch July 31, 2024 08:13
@STew790
Copy link
Contributor

STew790 commented Aug 15, 2024

QA OK
Font scales correctly with visibility settings.

Info

24.8.0 5cd19fd

@matejkriz matejkriz added the changelog User facing features that are potentionally worth mentioning in changelog label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vytick vytick vytick approved these changes

@shenkys shenkys Awaiting requested review from shenkys

Assignees
No one assigned
Labels
accessibility makes product user friendly for people with disabilities changelog User facing features that are potentionally worth mentioning in changelog mobile Suite Lite issues and PRs UI Issues related to stylistic/aesthetic changes
Projects
Suite Mobile
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejkriz @STew790 @vytick