Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code is inverted in dark mode #13083

Closed
matejcik opened this issue Jun 26, 2024 · 1 comment · Fixed by #13663
Closed

QR code is inverted in dark mode #13083

matejcik opened this issue Jun 26, 2024 · 1 comment · Fixed by #13663
Assignees
Labels
bug Something isn't working as expected good first issue Issue for newbie developers who want to participate

Comments

@matejcik
Copy link

Describe the bug
When the app is in dark mode, the QR code is shown with inverted colors.
This is non-standard and while some QR scanners can deal, not all of them, because they expect dark-on-light scheme.

Info:

  • Suite Version: web 24.6.2

How to reproduce

  1. enable dark mode
  2. go to a Receive tab
  3. show an address + QR code

Expected behavior
Dark-mode QR code should not be inverted. It should be the same as light-mode QR code, surrounded by at least one cell wide white border.

Screenshots
image image

Additional context
reported on the forum: https://forum.trezor.io/t/qr-code-cannot-be-scanned-in-dark-mode-both-trezor-suite-desktop-and-web-based-are-affected/18111/2

@matejcik matejcik added the bug Something isn't working as expected label Jun 26, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jun 26, 2024
@komret komret added the good first issue Issue for newbie developers who want to participate label Jul 10, 2024
@Lemonexe Lemonexe self-assigned this Aug 5, 2024
@MiroslavProchazka MiroslavProchazka moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Aug 7, 2024
@bosomt
Copy link
Contributor

bosomt commented Aug 8, 2024

QA OK

Image
Image

Info:

  • Suite version: desktop 24.8.1 (b8c7e5e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.8.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected good first issue Issue for newbie developers who want to participate
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants