Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM Tokens/ (un)hidden tokens are not reflected in transaction history #13039

Closed
Tracked by #12165
tomasklim opened this issue Jun 23, 2024 · 7 comments · Fixed by #13380
Closed
Tracked by #12165

EVM Tokens/ (un)hidden tokens are not reflected in transaction history #13039

tomasklim opened this issue Jun 23, 2024 · 7 comments · Fixed by #13380
Assignees
Labels
bug Something isn't working as expected

Comments

@tomasklim
Copy link
Member

tomasklim commented Jun 23, 2024

Describe the bug
When I unhide scam token, it is still marked as scam in tx history

Info:

  • Suite Version: develop

Expected behavior

  • I would expect that unhidden tokens are not marked anymore
  • I am not sure if I would expect that hidden tokens are now marked as "scam". Probably not
  • I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter
@tomasklim tomasklim added the bug Something isn't working as expected label Jun 23, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jun 23, 2024
@tomasklim tomasklim mentioned this issue Jun 23, 2024
@tomasklim tomasklim changed the title All token txs are marked as scam Hidden/unhidden tokens are not reflected in labeling tx Jun 24, 2024
@tomasklim
Copy link
Member Author

@Hannsek

@Hannsek
Copy link
Contributor

Hannsek commented Jun 25, 2024

I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter

Why would you like to do that?

I would expect that unhidden tokens are not marked anymore

Most probably yes, I am thinking about putting some warning after unhiding scammy tokens. But maybe not needed.

Seems like low prio.

@tomasklim
Copy link
Member Author

if we not do it 100% now, we will never do it 😀

@AdamSchinzel
Copy link
Contributor

I think this is quite important. I agree with not marking transactions with tokens that are unhidden as scammy but when I hide some token I would probably mark the transaction with this token as a scammy one. You hid it for some reason and you don't want to see it anymore.

I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter

True but I think it's not a big problem.

@tomasklim tomasklim changed the title Hidden/unhidden tokens are not reflected in labeling tx EVM Tokens/ (un)hidden tokens are not reflected in transaction history Jun 28, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Jul 17, 2024
@bosomt
Copy link
Contributor

bosomt commented Jul 19, 2024

QA NOK

#13380 (comment)

@bosomt bosomt reopened this Jul 19, 2024
@github-project-automation github-project-automation bot moved this from 🤝 Needs QA to 🎯 To do in Issues Suite Jul 19, 2024
@bosomt
Copy link
Contributor

bosomt commented Jul 23, 2024

QA NOK

now all tokens say unhide even they are recognized and not hidden :)

image

Info:

  • Suite version: web 24.8.0 (4a126f2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt reopened this Jul 23, 2024
@MiroslavProchazka MiroslavProchazka moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Aug 7, 2024
@bosomt
Copy link
Contributor

bosomt commented Aug 8, 2024

QA OK

Info:

  • Suite version: desktop 24.8.1 (b8c7e5e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.8.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants