-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Pane v2 #233
Comments
What kind of help do you need? |
First of all I need help in defining what a Here's a starter list:
Multiple panes support
and
Move Pane specific Props onto the
I'm open to suggestions on any ideas - and what should take priority - and keen to involve any one who wants to help design / develop etc... I'll try and push a branch that shows what I've got so far.... |
I'm up for lending a hand in developing. |
@whitecrownclown @wiesson Great! I'll get back soon with some plans - feel free to chip in with any ideas! |
Cool.. if possible, I too like contribute to this repo |
Would appreciate if percentage based panes could stay percentage based after resizing. Maybe put it behind a feature switch. It seems that in V1 it always uses pixels after manual resize |
If the split pane is mainly used for backend applications (or let's say modern browsers), then css grid could solve a lot of problems. |
Could you add support to allow custom classname for |
This looks preeetty freaking sweet! Not expecting it to be ready now or anything, but anything we should know if we want to try it out ourselves? Known major bugs or anything? Also, any idea when onChange/events might be supported? Really the only thing we need (to preserve position in local storage) that is not yet in there. |
Maybe publish to npm as |
@hongbo-miao good idea.... |
@tomkp hi, how do I import the |
@tomkp I cant see there is some way to pass import theme from './styles.css';
<SplitPane resizerClassName={theme.resizer}>
...
</SplitPane> Any change to get this new prop? |
@tomkp v2 demo looks really good. I'd like to contribute some improvements. I've made some experiments, you can find example here and my fork.
What do you think about it guys? If it's reasonable It would be my pleasure to make this great lib better. |
Are there API changes/breaking changes in Version 2.0? I don't see any docs to reference. Maybe I'm not looking in the right place. Thanks for the amazing project @tomkp |
How to import the |
@jaotors i've found the solution! You can impot the
|
is version 2 stable? seems stop update here |
hi all, is version 2 released? |
I think there's a problem when there's multiple UPDATE: Also, I cannot reproduce reliably, but sometimes, while using component, I got an error like this:
but then if I use Also, any progress on v2 release @wuweiweiwu @tomkp ? |
I do really need toggle panel feature. |
Were some of the main features like onDragStarted and onDragFinished removed? I'm trying to use them and it doesn't seem to be working properly. |
It seems like onDragStarted and onDragFinished were replaced by onResizeStart and onResizeEnd: |
Hello! Thanks for the nice module! |
Any updates? |
Any updates? |
Hi, I am getting the following warnings. @tomkp @wuweiweiwu any workaround for this? |
it would be awesome to have a hook-base version of this library!! I might play a little bit with this idea and come back with a POC |
Hi! Any ideas how to fix error while using http://react-split-pane-v2.surge.sh/?InitialPercentageVerticalExample
When I use Unhandled rejection Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. If I use |
I was able to fix this by directly importing the
|
i am currently working on the project where I have video at one side and content at the other side. if I use the dragged the contents are not responsive since the window width is not equal to pan width is there any way I can solve this? |
I'm willing to help! We need to get this project to the finish line! Vscode seems to have a really robost split pane with its split terminals. We could even start a whole new project and build from the ground up with hooks, typescript, and all the features others have requested such as double click, snapping, animated sliding, etc. The api for this project is a really good base to use. Anyone else interested in helping out? |
Hey guys, I wonder if someone could tell me that this repository is still being maintained or not :( |
Eagerly waiting for the stable release of v2. |
Hello @tomkp Thanks a lot for this library.
Styles
Link to codeSandbox => Link To recreate on condeSandbox: I know this is not yet stable. But any workaround. or any kind of suggestion will be very helpful. P.S. i have tried it with percentage value as well. still the issue is same. |
Hello @tomkp Thanks a lot for this library.
Solving the problem: replace |
@tomkp hi, can you help me, i can't run build :( |
@mystery078 were you able to resolve the issue I am also stuck with the same problem. |
u can build with react-script but not vite :( |
I upgraded to v.2 and found two small issues:
|
I'm working on an updated version of this library - using some updated methods and tooling.
I'll push a new branch soon for anyone interested in helping out...
The text was updated successfully, but these errors were encountered: