Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in the config file will be hidden from the user #36

Open
tobyweston opened this issue Nov 12, 2015 · 0 comments
Open

Errors in the config file will be hidden from the user #36

tobyweston opened this issue Nov 12, 2015 · 0 comments

Comments

@tobyweston
Copy link
Owner

The general behavior is to attempt to load the config file and if that fails, bootstrap a new conifg based on environment variables.

If the radiate.cfg for some reason fails (knobs fails to load), the error will be hidden and the bootstrap process will incorrectly kick off. The result is potentially misleading error message (for example, it might say the TEAMCITY_URL is missing rather than report that the file was bad).

See KnobsConfig.scala ~L21

It's the load orElse create behaviour that's to blame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant