Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page.update:after is dubbed #3

Open
wizhou opened this issue Feb 4, 2020 · 1 comment
Open

Page.update:after is dubbed #3

wizhou opened this issue Feb 4, 2020 · 1 comment

Comments

@wizhou
Copy link

wizhou commented Feb 4, 2020

Hello @texnixe, I was looking inside your plugin for some insights and saw that the hook page.update:after is written two times in hooks.php and with the same call to the static function Related::flush(). I don't know if this is relevant or not, I just wanted to point it out in case.

Here is the code inside the file :

return [
    // here 
    'page.update:after' => function() {
        Related::flush();
    },
    'page.create:after' => function() {
        Related::flush();
    },
    'file.create:after' => function() {
        Related::flush();
    },
    // and here 
    'page.update:after' => function() {
        Related::flush();
    }
];

Anyway, thank you for this nice plugin !

@texnixe
Copy link
Owner

texnixe commented Feb 4, 2020

Oh right, thanks for pointing that out, the second one should indeed by file.update:after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants