Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: remove redundant soil data mutations and restructure test_soil_data.py #1528

Open
shrouxm opened this issue Oct 31, 2024 · 0 comments
Open

Comments

@shrouxm
Copy link
Member

shrouxm commented Oct 31, 2024

Once all of our clients are using the pushSoilData mutation, there will be 4 redundant mutations:

  • updateSoilData
  • updateDepthDependentSoilData
  • updateSoilDataDepthInterval
  • deleteSoilDataDepthInterval

To keep our code surface smaller, we should remove these mutations.

Once we do that, we'll have to change most of the tests in test_soil_data.py which are currently testing these endpoints. Many of those tests are testing constraints and permissions conditions that should still be tested, but it might make more sense to test those at a different layer than graphql queries. So most of the work for this issue will be figuring out the right way to refactor that test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant