Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Refactoring #4449

Open
alionazherdetska opened this issue Jan 16, 2025 · 1 comment
Open

Header Refactoring #4449

alionazherdetska opened this issue Jan 16, 2025 · 1 comment
Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers

Comments

@alionazherdetska
Copy link
Contributor

alionazherdetska commented Jan 16, 2025

Current header structure
Image

After removing the popover-container and adjusting z-index values, I encountered an issue where the focus for post-list-items in the navigation gets cut off. This happens because the higher z-index of layer 2 is required to ensure the post-megadropdown-container remains hidden while it slides down during the animation from the top.

Aufzeichnung.2025-01-16.085640.mp4

A potential solution to this issue is to restructure the header and refactor it into two main containers.

Image

@alionazherdetska alionazherdetska added Header Everything related to our composible header components 📦 components Related to the @swisspost/design-system-components package labels Jan 16, 2025
@alionazherdetska alionazherdetska added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Jan 16, 2025
@alionazherdetska alionazherdetska changed the title Header structure Header Refactoring Jan 16, 2025
@gfellerph
Copy link
Member

@alionazherdetska, when re-structuring the header, these important factors have to be kept in mind:

  • The header is modular, the Application title and the links in the main slot are optional (see Design for Portal Header) and the header should work when content for these is not specified
  • The markup is responsive, meaning that the same markup needs to work on desktop and mobile
  • The header is already being implemented by the portal team. If anything in the required markup structure (for project implementation) changes, they need to be informed and it creates additional work

Have you considered alternatives like setting overflow: hidden on the megadropdown and moving the <post-popovercontainer> inside of it up and down for the animation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers
Projects
Status: 👀 Triage
Development

No branches or pull requests

2 participants