Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Job classes - group them in Audit module namespace #2057

Closed
3 of 4 tasks
ndushay opened this issue Nov 22, 2022 · 1 comment · Fixed by #2166
Closed
3 of 4 tasks

Audit Job classes - group them in Audit module namespace #2057

ndushay opened this issue Nov 22, 2022 · 1 comment · Fixed by #2166
Assignees
Labels
refactor architecture, refactoring, style, etc. tech debt

Comments

@ndushay
Copy link
Contributor

ndushay commented Nov 22, 2022

from storytime 2022-11-21

Audit job classes should all be in the "Audit" namespace. This includes

  • CatalogToMoabJob
  • ChecksumValidationJob
  • MoabToCatalogJob
  • Not sure about ValidateMoab -- it is possibly only run by preservation-robots as a check before ingest into prescat ... @justinlittman is working on understanding whether it is sometimes run as part of other three audits above - maybe ask him? -- NO. See PR add comments about use of ValidateMoabJob #2164

ALSO you should do a similar refactor into namespaces for service classes (@justinlittman do you agree)

  • checksum_validator --> should this be in audit namespace (Yes - it's already done.)
  • audit_results_reporter ... should this be in audit namespace (Possibly?)

having job names match queue names is ticketed separately as #2056

There is a separate ticket for CatalogToArchiveJob: #2059

note that the analogous replication audit refactoring is a separate ticket, #2059

analogous ticket for replication jobs is #2063

@ndushay
Copy link
Contributor Author

ndushay commented Dec 5, 2022

NOTE: wait for sidekiq to replace redis (#1984) in production before this change is merged to prod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor architecture, refactoring, style, etc. tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant