Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings modal should display next to icon trigger #22

Open
ggeisler opened this issue Jul 18, 2017 · 4 comments
Open

Settings modal should display next to icon trigger #22

ggeisler opened this issue Jul 18, 2017 · 4 comments

Comments

@ggeisler
Copy link

The icon that triggers the Settings modal is in the very top-right of the viewer, but the modal itself displays centered in the viewer. This creates a bit of a disconnect between the trigger of the action and the result of the action.

Instead, the Settings modal could behave similarly to the download and sharing actions. Display the modal as visually connected to the icon that triggers it:

universal_viewer_examples

Note that this mockup also replaces the "X" icon to close the modal with a Close button, as suggested in #20.

@edsilv
Copy link
Collaborator

edsilv commented Nov 14, 2017

This is something that requires UX discussion with the community. Will post on the slack channel.

@mialondon
Copy link

FWIW, I think this is fine. How would it look on small screen devices?

@sdellis
Copy link

sdellis commented Nov 14, 2017

In addition to the comments made by @ggeisler I think the "more info" link should go somewhere more meaningful to the settings context (currently links to the UV Github page). Perhaps it could point to something about further configuration (themes, visual config editor, etc.), or just be removed. Also, it seems to take up much more width than required for the dialogue, at least on a desktop.

@mialondon
Copy link

Agree about a more user-friendly link for 'more info' - is there something on http://universalviewer.io/ that'd suit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants