Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Membership Block doesn't support pending members. #68

Open
andrewlimaza opened this issue Apr 1, 2022 · 0 comments
Open

Require Membership Block doesn't support pending members. #68

andrewlimaza opened this issue Apr 1, 2022 · 0 comments
Milestone

Comments

@andrewlimaza
Copy link
Collaborator

The "Require Membership Block" is lacking filters to show/hide the block content and needs to be adjusted.

A workaround is to set the user's membership to false, as per this code snippet - #16 (comment)

The issue with this method is other things rely on the user having an active level, but still pending. Such as the non-member level text message tweaked slightly for pending Pay By Check Members.

A better long-term solution would be to add a filter to the output of the Block's PHP similar to the pmpro_member_shortcode_access filter for the [membership] shortcode.

Code reference: https://github.com/strangerstudios/paid-memberships-pro/blob/dev/blocks/membership/block.php#L39-L49

@andrewlimaza andrewlimaza added this to the V1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant