Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Limit in the Directory Add On limits the markers but they are random. #81

Open
3 tasks done
andrewlimaza opened this issue Mar 4, 2024 · 1 comment
Open
3 tasks done

Comments

@andrewlimaza
Copy link
Collaborator

Describe the bug
When adding the limit attribute to the Membership Directory shortcode or block, this limits the number markers shown on the map above the directory but it does not show the relevant members for that particular page.

Related/Similar: #49

To Reproduce
Steps to reproduce the behavior:

  1. Ensure you have both the directory and membership maps installed with a couple of members that are showing up on the map.
  2. Edit your directory shortcode or block adn set the limit to '1', and change the order by or order to ensure even more randomness to the output on the directory.
  3. See that the member shown on the directory would be X and the map marker would be Y.

Expected behavior
I feel that the markers shown on should reflect the members shown on the current view/page. It would be nice to have an option to show all markers on directory or show related markers to current view. It may need more discussion and thoughts around this as a solution.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
  • This bug happens with a default WordPress theme active, or Memberlite.
  • I can reproduce this bug consistently using the steps above.
@andrewlimaza
Copy link
Collaborator Author

A temporary solution is to force all the markers to show at once irrespective of the limit set by the Directory Add On. Here is a gist that may help - https://gist.github.com/JarrydLong/dead08183fb30b462ab402bfd5298dee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant