Update kubeconfig when invalid #627
Open
+83
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fyusel
commented
Jan 15, 2025
Fyusel
commented
- kubeconfig expires
- credentials rotation
- cluster recreation
- kubeconfig expires - credentials rotation - cluster recreation Signed-off-by: Alexander Dahmen <[email protected]>
bahkauv70
reviewed
Jan 15, 2025
| Description: descriptions["creation_time"], | ||
| Computed: true, | ||
| PlanModifiers: []planmodifier.String{ | ||
| stringplanmodifier.RequiresReplace(), |
There was a problem hiding this comment.
I'm not to sure here. Wouldn't RequiresReplace force a recreation of the cluster, when the creation time has been updated? I have'nt tested it though
bahkauv70
reviewed
Jan 15, 2025
| @@ -246,6 +257,21 @@ func (r *kubeconfigResource) Read(ctx context.Context, req resource.ReadRequest, | |||
| ctx = tflog.SetField(ctx, "cluster_name", clusterName) | |||
| ctx = tflog.SetField(ctx, "kube_config_id", kubeconfigUUID) | |||
|
|
|||
| cluster, err := r.client.GetClusterExecute(ctx, projectId, clusterName) | |||
There was a problem hiding this comment.
I would recommend to extract helper functions for this and the following block to keep this function a little bit shorter (and facilitate testing).
bahkauv70
reviewed
Jan 15, 2025
| return | ||
| } | ||
|
|
||
| creationTime, err := time.Parse("2006-01-02T15:04:05Z07:00", model.CreationTime.ValueString()) |
There was a problem hiding this comment.
the pattern is the same as time.RFC3339, we should use that one
bahkauv70
reviewed
Jan 15, 2025
|
|
||
| // check credentials rotation | ||
| if cluster.Status.CredentialsRotation.LastCompletionTime != nil { | ||
| lastCompletionTime, err := time.Parse("2006-01-02T15:04:05Z07:00", *cluster.Status.CredentialsRotation.LastCompletionTime) |
bahkauv70
reviewed
Jan 15, 2025
|
|
||
| // check cluster recreation | ||
| if cluster.Status.CreationTime != nil { | ||
| clusterCreationTime, err := time.Parse("2006-01-02T15:04:05Z07:00", *cluster.Status.CreationTime) |
bahkauv70
reviewed
Jan 15, 2025
There was a problem hiding this comment.
I would propose to add testcases for the added functionality (which would have to extracted to dedicated functions first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.