Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove search condition from VectorStoreDocumentRetriever #2067

Open
aRookieMan opened this issue Jan 14, 2025 · 0 comments
Open

Remove search condition from VectorStoreDocumentRetriever #2067

aRookieMan opened this issue Jan 14, 2025 · 0 comments

Comments

@aRookieMan
Copy link

public final class VectorStoreDocumentRetriever implements DocumentRetriever {

private final VectorStore vectorStore;

private final Double similarityThreshold;

private final Integer topK;

private final Supplier<Filter.Expression> filterExpression;

@Override
public List<Document> retrieve(Query query) {
	Assert.notNull(query, "query cannot be null");
	var searchRequest = SearchRequest.builder()
		.query(query.text())
		.filterExpression(this.filterExpression.get())
		.similarityThreshold(this.similarityThreshold)
		.topK(this.topK)
		.build();
	return this.vectorStore.similaritySearch(searchRequest);
}

}

I think that similarityThreshold\topK\filterExpression should be carried by Query. It can make VectorStoreDocumentRetriever be a singleton Object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant