Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert masks TypeError #135

Open
sakird opened this issue Dec 26, 2024 · 4 comments
Open

assert masks TypeError #135

sakird opened this issue Dec 26, 2024 · 4 comments
Assignees

Comments

@sakird
Copy link

sakird commented Dec 26, 2024

On line 101 of custom.py there is an assert line:

assert handler is not None

and below it, there is a TypeError raised if assert is true:

if handler is None: raise TypeError("Your input type to custom model is not currently supported")

this TypeError is not returning to developer and makes it hard to understand the cause of the error.

It seems asserting line is not necessary. Can we remove it?

@sakird
Copy link
Author

sakird commented Dec 26, 2024

Here is an image of relevant code and its link:

image

@sfc-gh-xjiang
Copy link

Hey @sakird , thanks for reporting this issue and we removed this assertion in the next release.

Apart from the the assertion, is it possible for you to provide a minimal reproducible example so that we can help investigate the issue?

Thanks,
Xinyi

@sfc-gh-xjiang sfc-gh-xjiang self-assigned this Jan 9, 2025
@sakird
Copy link
Author

sakird commented Jan 9, 2025

Would it be OK to provide code here as a comment? Or is there any other way for that? I did not do anything like this before.

@sfc-gh-xjiang
Copy link

sfc-gh-xjiang commented Jan 9, 2025

Hey @sakird, you can delete your sensitive information, create dummy data and share codes in the comment.
Otherwise, if you have any point of contact sales engineer, you can also share with them and i'm happy to help.

Thanks
Xinyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants