Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Broken; Signature only allowing one click at a time #36

Open
tominal opened this issue Dec 5, 2024 · 4 comments · May be fixed by #37
Open

[Bug]: Broken; Signature only allowing one click at a time #36

tominal opened this issue Dec 5, 2024 · 4 comments · May be fixed by #37
Labels
bug Something isn't working

Comments

@tominal
Copy link

tominal commented Dec 5, 2024

What happened?

On mouseup, the signature is immediately finalized without allowing additional characters in a signature.

How to reproduce the bug

Follow the instructions for 2.0

Package Version

2.0.0

PHP Version

8.3

Laravel Version

10.48.25

Which operating systems does with happen with?

Linux

Notes

Filament version: 3.2.128

Adding ->reactive(false) breaks the field significantly as well but that can be considered a separate issue.
@tominal tominal added the bug Something isn't working label Dec 5, 2024
@tominal
Copy link
Author

tominal commented Dec 6, 2024

2024-12-05.18-02-13.mp4

@tuimz
Copy link

tuimz commented Dec 23, 2024

Any workaround for this? I have the same issue.

@tuimz tuimz linked a pull request Dec 23, 2024 that will close this issue
Open
@tominal
Copy link
Author

tominal commented Dec 23, 2024

Any workaround for this? I have the same issue.

I ended up using saade/filament-autograph

@tuimz
Copy link

tuimz commented Dec 23, 2024

Any workaround for this? I have the same issue.

I ended up using saade/filament-autograph

Cheers for that, if my PR ends up not getting merged I might switch over soon too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolving issue empty before 2nd drawing. tuimz/filament-signature-pad
2 participants
@tuimz @tominal