Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SAFE_TX_TYPEHASH value is wrong for < 1.0.0 Safe versions #1070

Open
pcaversaccio opened this issue Dec 6, 2024 · 1 comment
Open

The SAFE_TX_TYPEHASH value is wrong for < 1.0.0 Safe versions #1070

pcaversaccio opened this issue Dec 6, 2024 · 1 comment

Comments

@pcaversaccio
Copy link

Safe multisig versions < 1.0.0 use a legacy (i.e. the parameter value baseGas was called dataGas previously) SAFE_TX_TYPEHASH value. Starting with version 1.0.0, baseGas was introduced: safe-global/safe-smart-account#90.

SafeTx: [
{ type: 'address', name: 'to' },
{ type: 'uint256', name: 'value' },
{ type: 'bytes', name: 'data' },
{ type: 'uint8', name: 'operation' },
{ type: 'uint256', name: 'safeTxGas' },
{ type: 'uint256', name: 'baseGas' },
{ type: 'uint256', name: 'gasPrice' },
{ type: 'address', name: 'gasToken' },
{ type: 'address', name: 'refundReceiver' },
{ type: 'uint256', name: 'nonce' }
]
}
}

@pcaversaccio pcaversaccio changed the title SAFE_TX_TYPEHASH value is wrong for <1.0.0 Safe versions. The SAFE_TX_TYPEHASH value is wrong for < 1.0.0 Safe versions Dec 6, 2024
@pcaversaccio
Copy link
Author

Fwiw, I shipped support now for Safe versions 0.1.0 in my Bash script: pcaversaccio/safe-tx-hashes-util#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant