Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-kit): add missing properties to types #1100

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix(api-kit): add missing properties to types #1100

wants to merge 2 commits into from

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 16, 2025

What it solves

Resolves #1064, #1085, #1088

How this PR fixes it

Adds missing properties to types

This was linked to issues Jan 16, 2025
SafeMultisigTransactionResponse dataDecoded field's type #1064
Open
Get Incoming Transaction response type #1085
Open
[APIKit] Type mistmatch between txs-service and SDK #1088
Open
@dasanra dasanra requested review from DaniSomoza and yagopv January 16, 2025 16:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12827811026

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 75.199%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/SafeApiKit.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 12811371480: -0.04%
Covered Lines: 797
Relevant Lines: 987
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

@yagopv yagopv Awaiting requested review from yagopv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dasanra @coveralls