Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review PR about UD21x18 and SD21x18 #15

Closed
PaulRBerg opened this issue Dec 15, 2023 · 6 comments
Closed

Review PR about UD21x18 and SD21x18 #15

PaulRBerg opened this issue Dec 15, 2023 · 6 comments
Assignees
@PaulRBerg
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

See PaulRBerg/prb-math#212
@PaulRBerg PaulRBerg self-assigned this Dec 15, 2023
@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed feature labels Jan 1, 2024
@smol-ninja
Copy link
Member

Is it relevant to this repo @PaulRBerg? Why is it open here?

@PaulRBerg
Copy link
Member Author

It is relevant. @andreivladbrg can provide more details.

@andreivladbrg
Copy link
Member

andreivladbrg commented Apr 10, 2024 •
edited
Loading

It would be helpful to have UD21x18 - custom type for uint128 - because rps is an 18-decimal number, this would improve the DX, similar to the exponent - custom type for uint64 - in the LockupDynamic contract.

Regarding Shub’s question, I think he is referring to why we need a separate issue on this repository besides the PR on PRBMath, right @smol-ninja? If this is the case, I guess PRB likes to have issues as for TODO list.

@smol-ninja
Copy link
Member

Yes @andreivladbrg, your guess is spot on, thats what I meant.

@PaulRBerg
Copy link
Member Author

I guess PRB likes to have issues as for TODO list

Correct

https://twitter.com/PaulRBerg/status/1743212082101653735

@smol-ninja smol-ninja added priority: 2 We will do our best to deal with this. and removed priority: 0 Do this first before everything else. This is critical and nothing works without this. labels Apr 15, 2024
@andreivladbrg
Copy link
Member

The PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg