New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up find_roots_gen #211

Open

rparini opened this issue Aug 18, 2022 · 0 comments

Labels

Owner

rparini commented Aug 18, 2022 •

edited

Loading

It's a very long generator with several functions defined within it so hard to read. Might want to be a class with methods instead.

There are also some special cases and adaptive adjustments in the code that are not tested

rparini added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment