Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests broken on OS X #7

Closed
thomas-moulard opened this issue Apr 20, 2020 · 4 comments
Closed

CI tests broken on OS X #7

thomas-moulard opened this issue Apr 20, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@thomas-moulard
Copy link
Member

Description

Tests broken on OS X:

2020-04-20T19:24:22.8349430Z [14.088s] The following tests FAILED:
2020-04-20T19:24:22.8349850Z [14.088s] 	  1 - test_collector (Failed)
2020-04-20T19:24:22.8350270Z [14.088s] 	  2 - test_moving_average_statistics (Failed)
2020-04-20T19:24:22.8350680Z [14.088s] 	  3 - test_received_message_period (Failed)
2020-04-20T19:24:22.8351080Z [14.088s] 	  4 - test_received_message_age (Failed)
2020-04-20T19:24:22.8351180Z [14.133s] Errors while running CTest

https://pipelines.actions.githubusercontent.com/770SLwBj3ET8NDQCRWFqpZmRWXkXzxULg9phWHBbZVu2jXGrW5/_apis/pipelines/1/runs/126/signedlogcontent/6?urlExpires=2020-04-20T19%3A53%3A59.6774078Z&urlSigningMethod=HMACV1&urlSignature=kOrEbPjDAN8O2b10B43olmT0lAJgPn4IaRNqs1GPPsI%3D

To Reproduce

CI Run https://github.com/ros-tooling/libstatistics_collector/actions

System (please complete the following information)

  • OS: OS X
  • ROS 2 Distro: master

Additional context

N/A

@thomas-moulard thomas-moulard added the bug Something isn't working label Apr 20, 2020
@dabonnie
Copy link
Contributor

dabonnie commented Apr 23, 2020

I went down the path of trying to lookup the error

dyld: Library not loaded: @rpath/libspdlog.1.dylib

and found a few threads. This was interesting and I'm not familiar with the image, but wondering if SIP is enabled? Either way I found a few missing brew dependencies and have opened a PR: ros-tooling/setup-ros#127

@dabonnie
Copy link
Contributor

dabonnie commented Apr 23, 2020

Using the draft PR #9 I was able to verify that SIP is enabled on OSX

Mac-1557:libstatistics_collector runner$ csrutil status
System Integrity Protection status: enabled.

Opened a ticket against setup-ros: ros-tooling/setup-ros#128

@dabonnie
Copy link
Contributor

This appears to be fixed by #10 and is unrelated to ros-tooling/setup-ros#128.

@dabonnie
Copy link
Contributor

Closing given green CI and the fix #10 via @thomas-moulard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants