Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcs-repo-file-url should default to empty, rather than master ros2.repos #561

Closed
emersonknapp opened this issue Mar 5, 2021 · 4 comments · Fixed by #566
Closed

vcs-repo-file-url should default to empty, rather than master ros2.repos #561

emersonknapp opened this issue Mar 5, 2021 · 4 comments · Fixed by #566
Assignees
@christophebedard
Labels
enhancement New feature or request

Comments

@emersonknapp
Copy link
Contributor

Description

The default value for vcs-repo-file-url has been a recurring point of confusion for users, because it often pulls in a newer version of the code than they are trying to build against.

Related Issues

#559

Completion Criteria

Defaults to not using an external .repos file

Implementation Notes / Suggestions

Change the default in action.yml

This may break users who depend on this default value, so I'm somewhat inclined to bump minor version to v0.2 if we do this

Testing Notes / Suggestions
@emersonknapp emersonknapp added the enhancement New feature or request label Mar 5, 2021
@emersonknapp emersonknapp mentioned this issue Mar 5, 2021
Closed
@christophebedard
Copy link
Member

@emersonknapp this existing issue seems pretty relevant: #316

@emersonknapp
Copy link
Contributor Author

Yes, you're right. I think the original suggestion there was to default to the distro under build, but in the conversation we came to this conclusion as an alternative. I'm not quite sure this is duplicate, but only one of these tickets needs to be solved, I think

@christophebedard
Copy link
Member

I think the original suggestion there was to default to the distro under build, but in the conversation we came to this conclusion as an alternative. I'm not quite sure this is duplicate, but only one of these tickets needs to be solved, I think

yeah. I'm still in favour of changing the overall approach as mentioned in #316 (comment), but I can just open a separate issue since this one is more for a short-term solution/fix.

@christophebedard
Copy link
Member

@emersonknapp can you assign this to me? Unless you were planning on doing the change.

@christophebedard christophebedard mentioned this issue Mar 6, 2021
Merged
emersonknapp pushed a commit that referenced this issue Mar 9, 2021
@christophebedard
Default to empty vcs-repo-file-url (#566)
e2bb22a 
Fixes #561

This changes the default value for the `vcs-repo-file-url` input to an empty
string. Therefore, by default, action-ros-ci will rely on binaries
(e.g. installed by setup-ros) for any dependencies.

Signed-off-by: Christophe Bedard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophebedard christophebedard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default to empty vcs-repo-file-url
2 participants
@emersonknapp @christophebedard