Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect support automatic rapp installation #212

Closed
bit-pirate opened this issue Apr 21, 2014 · 3 comments
Closed

Auto-detect support automatic rapp installation #212

bit-pirate opened this issue Apr 21, 2014 · 3 comments

Comments

@bit-pirate
Copy link
Collaborator

Better than setting a parameter in the app manager's roslauncher would be an automatic detection of whether or not everything has been set up to support automatic installation of apps.

Our current method is enabling password-less installation using apt-get via sudoers (see #211 for more details).

One method of detecting, if this has been set-up, is actually trying to install a know to be available package (sth standard). However, if in the same shell the user has provided the sudo password before - let's say for the manual installation of a package - the app manager could falsely detect automatic app installation has been enabled.

Need to put some thinking in this to enable a robust detection of this.

@stonier
Copy link
Member

stonier commented Apr 24, 2014

  1. Just launch a command in a python subprocess with a fresh shell, that should work.

  2. Don't even worry about it, just proceed to try every time the user asks to start a rapp, and if it works, great, if it doesn't, pop out a warning of decent immensity and obviality to the user.

I prefer 2).

@stonier
Copy link
Member

stonier commented Apr 24, 2014

  1. is bad. The concert then cannot be sure if such a resource is allocatable before starting it.

So yeah, we have to validate at startup, i.e. detect whether the user can run sudo with apt-get or rosdep or similar.

I don't think we have to go as far as detecting if the user has got temporary sudo access though. It is a minor use case and because it is human interactive, we can always throw them a noisy warning later when an automatic install fails.

@stonier
Copy link
Member

stonier commented Aug 14, 2015

Not going to support this in its current incarnation. We'll pick it up again and probably slightly differently in future incarnations.

@stonier stonier closed this as completed Aug 14, 2015
@stonier stonier self-assigned this Aug 14, 2015
@stonier stonier added this to the Indigo - Legacy milestone Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants