Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclass-wizard incompatible with Python 3.13 #128

Closed
erikpragt-connectid opened this issue Oct 11, 2024 · 4 comments
Closed

dataclass-wizard incompatible with Python 3.13 #128

erikpragt-connectid opened this issue Oct 11, 2024 · 4 comments
Labels
acknowledged breaking High Priority! bug Something isn't working

Comments

@erikpragt-connectid
Copy link

  • Dataclass Wizard version: 0.23.0
  • Python version: 3.13
  • Operating System: Mac

Description

In models.py, there's a reference to the private function called _create_fn. This function has been removed in Python 3.13:

https://github.com/python/cpython/blob/2f8301cbfbdd2976d254a4a772b4879069dd4298/Lib/dataclasses.py#L491

As a result, dataclass-wizard no longer works. As a solution, maybe the _create_fn can be copied, or maybe a whole different approach is needed, I'm not sure.

@benjjs
Copy link
Contributor

benjjs commented Oct 21, 2024

Put up #129 to address this but will need to get @rnag's attention.

@rnag
Copy link
Owner

rnag commented Nov 4, 2024

Hey guys, sorry for the delay. I'm looking into this now.

@rnag
Copy link
Owner

rnag commented Nov 4, 2024

@benjjs Your PR looks good and seems it would solve the compatibility issue with 3.13. I added some notes, mostly minor stuff. Let me know when you're able to look into it, but it LGTM otherwise. Thanks!

@rnag rnag added bug Something isn't working acknowledged breaking High Priority! labels Nov 4, 2024
@rnag
Copy link
Owner

rnag commented Nov 6, 2024

Closing, as this is fixed by #129.

@rnag rnag closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged breaking High Priority! bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants